DamianPendrak commented on code in PR #36890:
URL: https://github.com/apache/superset/pull/36890#discussion_r2658885415
##########
superset-frontend/plugins/legacy-preset-chart-deckgl/src/layers/Scatter/buildQuery.ts:
##########
@@ -78,15 +80,25 @@ export default function buildQuery(formData:
DeckScatterFormData) {
columns = withJsColumns as QueryFormColumn[];
columns = addTooltipColumnsToQuery(columns, tooltip_contents);
- const metrics = processMetricsArray([point_radius_fixed?.value]);
+ // Only add metric if point_radius_fixed is a metric type
+ const isMetric = isMetricValue(point_radius_fixed);
+ const metricValue = isMetric ?
extractMetricKey(point_radius_fixed?.value) : null;
+
+ // Preserve existing metrics and only add radius metric if it's
metric-based
+ const existingMetrics = baseQueryObject.metrics || [];
+ const radiusMetrics = processMetricsArray(
+ metricValue ? [metricValue] : [],
+ );
+ const metrics = [...existingMetrics, ...radiusMetrics];
Review Comment:
This line causes an error when there are duplicated metrics in
existingMetrics and radiusMetrics. To replicate, run Superset with fresh
examples and go to deck.gl demo dashboard
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
