EnxDev commented on code in PR #36332:
URL: https://github.com/apache/superset/pull/36332#discussion_r2661698019
##########
superset-frontend/src/explore/components/SaveModal.tsx:
##########
@@ -236,6 +257,12 @@ class SaveModal extends Component<SaveModalProps,
SaveModalState> {
? sliceDashboards
: [...sliceDashboards, dashboard.id];
formData.dashboards = sliceDashboards;
+ if (
+ this.state.action === 'saveas' &&
Review Comment:
How about centralizing them in a typed constant object or enum?
##########
superset-frontend/src/explore/components/SaveModal.tsx:
##########
@@ -409,6 +657,27 @@ class SaveModal extends Component<SaveModalProps,
SaveModalState> {
}
/>
</FormItem>
+ {this.state.action === 'saveas' && (
Review Comment:
here as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
