michael-s-molina commented on PR #36644: URL: https://github.com/apache/superset/pull/36644#issuecomment-3710807174
Thank you for the latest changes @justinpark. I have some design suggestions that could be addressed in follow-up PRs but I think it would be easier to do them in this PR so that @kasiazjc can review the final form of the screen. <img width="1908" height="860" alt="Screenshot 2026-01-05 at 11 10 42" src="https://github.com/user-attachments/assets/64143794-4ca3-4e25-a56c-3cf83cf315fa"; /> 1. I think the tabs and buttons are a little too big and taking more vertical space than needed. My suggestion would be to use a smaller size to all. 2. The vertical blank space in the editor, reserved for the line numbers, is a little confusing given that we're using the white/grey contrast to separate part of the screen. My suggestion would use the same background as the rest of the editor and add a separator. 3. The editor's handle to drag has a darker background when comparing with the editor's background, creating the illusion of a border. I would use the same background color. 4. Given that the editor is grey, I would use a white background for the panels to give more contrast. Something like this: <img width="1908" height="863" alt="Screenshot 2026-01-05 at 11 51 10" src="https://github.com/user-attachments/assets/2f61c909-1a93-4caf-8b57-ef735e85068f"; /> @kasiazjc These are just suggestions and I bet you can get to something even better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
