codeant-ai-for-open-source[bot] commented on PR #36905: URL: https://github.com/apache/superset/pull/36905#issuecomment-3711493953
## Nitpicks 🔍 <table> <tr><td>🔒 <strong>No security issues identified</strong></td></tr> <tr><td>⚡ <strong>Recommended areas for review</strong><br><br> - [ ] <a href='https://github.com/apache/superset/pull/36905/files#diff-2b4e1e0468caf93c2e992bc521e86082bba0f33c8a31137f6d9dc80a70c19e92R118-R136'><strong>Accessibility</strong></a><br>The new decorative/semantic icons (filter and divider) are rendered without ARIA attributes or labels. Screen readers may not know whether these icons convey meaningful information. Decide whether the icons are purely decorative (use aria-hidden="true") or convey semantics (add aria-label/role="img") and apply consistently.<br> - [ ] <a href='https://github.com/apache/superset/pull/36905/files#diff-2b4e1e0468caf93c2e992bc521e86082bba0f33c8a31137f6d9dc80a70c19e92R118-R136'><strong>Icon semantics & keyboard interaction</strong></a><br>The icons are added next to clickable rows — ensure they don't intercept keyboard focus or clicks unexpectedly. If an icon should be clickable / interactive, it needs keyboard handlers and accessible names; if decorative, mark it aria-hidden. Also check visual focus order after icons are added.<br> </td></tr> </table> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
