bito-code-review[bot] commented on PR #36893:
URL: https://github.com/apache/superset/pull/36893#issuecomment-3711536202
<!-- Bito Reply -->
Yes, the suggestion is valid — adding a catch block to the async IIFE in
index.tsx would prevent unhandled promise rejections from initPreamble() and
allow error logging for debugging, mirroring the error handling pattern in
preamble.ts lines 141-143.
**superset-frontend/src/views/index.tsx**
```
(async () => {
try {
await initPreamble();
} finally {
const { default: App } = await import('./App');
ReactDOM.render(<App />, appMountPoint);
}
})();
```
**superset-frontend/src/preamble.ts**
```
void initPreamble().catch(err => {
console.warn('Preamble initialization failed.', err);
});
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
