codeant-ai-for-open-source[bot] commented on PR #36906: URL: https://github.com/apache/superset/pull/36906#issuecomment-3711654854
## Nitpicks 🔍 <table> <tr><td>🔒 <strong>No security issues identified</strong></td></tr> <tr><td>⚡ <strong>Recommended areas for review</strong><br><br> - [ ] <a href='https://github.com/apache/superset/pull/36906/files#diff-9d8a7d8c3551176d3b78bd41aa2f8caab246adace29770c13deb08aa7efc26e9R119-R129'><strong>Fragile port parsing</strong></a><br>`get_running_port` parses `docker compose port` output by cutting on ':' and taking field 2. This can break for IPv6 addresses, multi-colon formats, or unexpected output formats. It could produce empty or incorrect port values.<br> - [ ] <a href='https://github.com/apache/superset/pull/36906/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R135-R137'><strong>Script existence / permissions</strong></a><br>The new `ports` and `open` targets call `./scripts/docker-compose-up.sh`. The Makefile assumes that script exists and is executable; if it is missing or not executable the targets will fail with a cryptic message. Consider adding a guard or clearer error handling to surface actionable errors.<br> - [ ] <a href='https://github.com/apache/superset/pull/36906/files#diff-9d8a7d8c3551176d3b78bd41aa2f8caab246adace29770c13deb08aa7efc26e9R164-R174'><strong>Browser open portability</strong></a><br>`open_browser` only tries `open` and `xdg-open`. Windows/WSL environments or other systems may need `wslview`, `powershell.exe /c start`, or other handlers. Users on those platforms may not get the browser opened.<br> </td></tr> </table> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
