bito-code-review[bot] commented on code in PR #36908: URL: https://github.com/apache/superset/pull/36908#discussion_r2663366266
########## docs/netlify.toml: ########## @@ -0,0 +1,53 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# Netlify configuration for Superset documentation +# This enables automatic deploy previews for PRs that modify docs + +[build] + # Base directory is the docs folder + base = "docs" + # Build command for Docusaurus + command = "yarn install && yarn build" + # Output directory (relative to base) + publish = "build" + +[build.environment] + # Node version matching docs/.nvmrc + NODE_VERSION = "20" + # Yarn version + YARN_VERSION = "1.22.22" + +# Deploy preview settings +[context.deploy-preview] + command = "yarn install && yarn build" + +# Branch deploy settings (for feature branches) +[context.branch-deploy] + command = "yarn install && yarn build" + +# Redirect /docs to the main docs page +[[redirects]] Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Incorrect redirect configuration</b></div> <div id="fix"> The redirect from "/docs" to "/docs/intro" appears incorrect for a documentation site; typically, the root "/" should redirect to the main docs page "/docs/intro" to provide a clean entry point, rather than redirecting the docs index itself. </div> </div> <small><i>Code Review Run #112bd9</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
