massucattoj commented on code in PR #36983:
URL: https://github.com/apache/superset/pull/36983#discussion_r2672643646
##########
superset/utils/date_parser.py:
##########
@@ -431,8 +431,8 @@ def get_since_until( # pylint:
disable=too-many-arguments,too-many-locals,too-m
),
),
(
- r"^(this|last|next|prior)\s+"
- r"([0-9]+)?\s*"
+ r"^(this|last|next|prior)\s{1,5}"
+ r"([0-9]+)?\s{0,5}"
r"(second|minute|day|week|month|quarter|year)s?$", # Matches
"next 5 days" or "last 2 weeks" # noqa: E501
Review Comment:
Seems that there is no need to handle hour here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]