VanessaGiannoni opened a new pull request, #36990: URL: https://github.com/apache/superset/pull/36990
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> Fixes a case-sensitivity issue causing table aggregation to break when a temporal column is renamed with different casing. The `time_grain_sqla` visibility check in the AG Grid Table control panel is made case-insensitive, ensuring time grain aggregation is applied even after renaming. Adds a unit test to prevent regressions. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> 1. In Explore, create a Table chart with a dataset that has an uppercase temporal column (e.g., `ORDERDATE`). 2. Enable Aggregate, add the temporal column to Dimensions, set Month time grain, update chart. Verify aggregation works. 3. Rename the temporal column to lowercase (e.g., `orderdate`) and update chart. 4. Verify aggregation still follows the selected time grain. Unit test: - From superset-frontend, run: - `npm run test -- plugins/plugin-chart-ag-grid-table/test/controlPanel.test.ts` ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
