LuisSanchez opened a new pull request, #36993:
URL: https://github.com/apache/superset/pull/36993

   ### SUMMARY
   
   #### Problem
   Charts had too much left margin by default.
   
   #### Solution
   - Add 0 margin as an option (and default) on the X and Y axis
   - Automatically set margin to 30 when an axis title is added and margin is 0
   - Automatically reset margin to 0 when an axis title is removed
   - Apply padding offsets only when both title exists and margin is non-zero
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   #### BEFORE
   <img width="1692" height="820" alt="image" 
src="https://github.com/user-attachments/assets/10ed4786-441f-4cc4-b046-ae00b250ae89";
 />
   
   #### AFTER
   
https://github.com/user-attachments/assets/b6b7bb4c-8254-4424-87fb-9356ff77ebc1
   
   ### TESTING INSTRUCTIONS
   
   1. Add a new chart.
   2. Check the left margin that is too big, instead of 0.
   3. Add a title on the Y axis and see how it grows automatically.
   4. Add a title on the X axis and see how it grows automatically.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: 96451
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to