codeant-ai-for-open-source[bot] commented on PR #37014: URL: https://github.com/apache/superset/pull/37014#issuecomment-3729473509
## Nitpicks 🔍 <table> <tr><td>🔒 <strong>No security issues identified</strong></td></tr> <tr><td>⚡ <strong>Recommended areas for review</strong><br><br> - [ ] <a href='https://github.com/apache/superset/pull/37014/files#diff-595987046ff00d1af428f8b7360bdd1372bef133a42e58ff8ede585ea98cd254R2390-R2399'><strong>Timezone handling</strong></a><br>The new logic subtracts a fixed hours offset from start/end datetimes to convert "local" bounds to UTC. This simplistic arithmetic can be incorrect for timezone-aware datetimes, DST transitions, or when the configured offset is not a pure fixed-hour offset. Verify correctness for tz-aware inputs, DST-boundary dates, and whether the dataset `offset` is intended to be a fixed offset or a timezone identifier.<br> - [ ] <a href='https://github.com/apache/superset/pull/37014/files#diff-595987046ff00d1af428f8b7360bdd1372bef133a42e58ff8ede585ea98cd254R2395-R2399'><strong>Type assumptions</strong></a><br>The code assumes `start_dttm` / `end_dttm` are Python datetimes and that `self.offset` is an hours integer. In practice these values can be pd.Timestamp, strings, or floats (fractional hours). Confirm input types and coerce/validate before arithmetic to avoid silent bugs.<br> </td></tr> </table> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
