bito-code-review[bot] commented on code in PR #37019:
URL: https://github.com/apache/superset/pull/37019#discussion_r2677288656
##########
tests/unit_tests/db_engine_specs/test_redshift.py:
##########
@@ -49,3 +50,32 @@ def test_convert_dttm(
)
assert_convert_dttm(spec, target_type, expected_result, dttm)
+
+
[email protected](
+ "table_name,schema_name,expected_table,expected_schema",
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Parametrize names should be tuple not string</b></div>
<div id="fix">
The first argument to `pytest.mark.parametrize` on line 56 should be a tuple
of strings, not a single string. Change
`"table_name,schema_name,expected_table,expected_schema"` to `("table_name",
"schema_name", "expected_table", "expected_schema")`.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
````suggestion
("table_name", "schema_name", "expected_table", "expected_schema"),
````
</div>
</details>
</div>
<small><i>Code Review Run #d99e61</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
