DamianPendrak opened a new pull request, #36062:
URL: https://github.com/apache/superset/pull/36062
## **User description**
### SUMMARY
1. Adds Chart Customizations to the "Edit filters" modal. Time Grain and
Time Column moved from Filters to the Chart Customizations. Chart
Customizations can now be added using plugins just like Filters. Continuation
of #33831.
2. Add deck.gl Layer Visibility chart customization - allows for hiding
layers in Multi Layer Deck.gl Chart
**Requirements for chart customizations:**
Replace current structure (separate "Add filter" / "Add customization" /
"Add divider" buttons)
With: Single dropdown button
- Button label: "+ New" (secondary button)
- Dropdown options:
- Filter
- Customization
- Divider
Add collapsible sections (like dataset folders in Explore):
**Section 1: Filters**
- Contains all filter items
- User can reorder items within this section only
**Section 2: Customization**
- Contains all customization controls:
- Dynamic group by
- Time column
- Time grain
- Hide layers (deck.gl)
User can reorder items within this section only
Important constraint: Customization controls cannot be moved to Filters
section and vice versa
<img width="687" height="637" alt="Screenshot 2025-11-19 at 17 37 02"
src="https://github.com/user-attachments/assets/5b8a5d14-2e42-488c-93ad-4da728ac5c01";
/>
---
**Requirements for Deck.gl Layer Visibility customization:**
BY DEFAULT IT’S A MULTISELECT
- Functions as an inverse selection filter with multiselect field
- By default, all available layers from deck.gl charts are displayed
- User selects layers to exclude from charts
- Shows tooltip on hover always for this typeomization settings)
- Applies to all deck.gl Multiple Layer charts in the dashboard
**Design and requirements for reordering layers:**
<img width="995" height="528" alt="Screenshot 2025-11-19 at 17 35 12"
src="https://github.com/user-attachments/assets/3a855e08-b82e-4d51-b58f-b530f36ecb38";
/>
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<img width="901" height="850" alt="Screenshot 2025-11-11 at 00 40 07"
src="https://github.com/user-attachments/assets/6deea600-fdd6-4ea8-9ecc-8f315f5ca792";
/>
<img width="1492" height="1039" alt="Screenshot 2025-11-19 at 12 33 36"
src="https://github.com/user-attachments/assets/c4fb5bfd-695f-4968-86c6-e825c4ccb2f5";
/>
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
___
## **CodeAnt-AI Description**
**Unify configuration: edit filters and chart customizations in one modal
and persist changes**
### What Changed
- The Filters modal is redesigned to include two collapsible sections
(Filters and Customization) with a sidebar and content pane so you can add and
edit chart customizations (dynamic group by, time grain, deck.gl layer
visibility) alongside native filters in the same place.
- Chart customizations are rendered in the filter bar as filter-like
controls (cards) — selecting a column or value updates a pending customization
state, shows loading/errors while loading dataset columns, and can be required;
these pending customization changes are applied together with filters when you
click Apply.
- Apply now persists pending chart customization changes to the dashboard
and triggers chart updates; Clear All resets customization selections and can
clear saved customization columns/data masks.
- Deck.gl layer visibility is supported as a chart customization and the
query schema includes visible_deckgl_layers so multi-layer deck.gl charts
respect hidden layers chosen in customization.
### Impact
`✅ Configure filters and chart customizations from one modal`
`✅ Persist chart customization changes when applying filters`
`✅ Hide layers in multi-layer deck.gl charts from dashboard`
<details>
<summary><strong>💡 Usage Guide</strong></summary>
### Checking Your Pull Request
Every time you make a pull request, our system automatically looks through
it. We check for security issues, mistakes in how you're setting up your
infrastructure, and common code problems. We do this to make sure your changes
are solid and won't cause any trouble later.
### Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can
easily get in touch with CodeAnt AI right here. Just type the following in a
comment on your pull request, and replace "Your question here" with whatever
you want to ask:
<pre>
<code>@codeant-ai ask: Your question here</code>
</pre>
This lets you have a chat with CodeAnt AI about your pull request, making it
easier to understand and improve your code.
#### Example
<pre>
<code>@codeant-ai ask: Can you suggest a safer alternative to storing this
secret?</code>
</pre>
### Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future
reviews. Reply directly to the specific CodeAnt AI suggestion (in the same
thread) and replace "Your feedback here" with your input:
<pre>
<code>@codeant-ai: Your feedback here</code>
</pre>
This helps CodeAnt AI learn and adapt to your team's coding style and
standards.
#### Example
<pre>
<code>@codeant-ai: Do not flag unused imports.</code>
</pre>
### Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
<pre>
<code>@codeant-ai: review</code>
</pre>
### Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at
[https://app.codeant.ai](https://app.codeant.ai). This tool helps you identify
potential issues and areas for improvement in your codebase, ensuring your
repository maintains high standards of code health.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
