codeant-ai-for-open-source[bot] commented on PR #37029: URL: https://github.com/apache/superset/pull/37029#issuecomment-3732853220
## Nitpicks 🔍 <table> <tr><td>🔒 <strong>No security issues identified</strong></td></tr> <tr><td>⚡ <strong>Recommended areas for review</strong><br><br> - [ ] <a href='https://github.com/apache/superset/pull/37029/files#diff-9f73a319dfdacecfd026e7bfdaaa4826c69cb40aba177bb2da3ce63439cc109eR100-R140'><strong>Cross-layer consistency</strong></a><br>Confirm GeoJSON and other DeckGL layer control panels have consistent stroke color visibility and behavior. The change here affects only Polygon; ensure similar behavior (and tests) exist where appropriate so users have a consistent experience across layers.<br> - [ ] <a href='https://github.com/apache/superset/pull/37029/files#diff-9f73a319dfdacecfd026e7bfdaaa4826c69cb40aba177bb2da3ce63439cc109eR120-R124'><strong>Control reactivity</strong></a><br>Ensure the stroke color control updates the visualization immediately when changed (renderTrigger) and that removing the previous visibility condition does not leave the UI in an inconsistent state when certain color scheme types are selected (e.g., breakpoints or linear palettes).<br> - [ ] <a href='https://github.com/apache/superset/pull/37029/files#diff-9f73a319dfdacecfd026e7bfdaaa4826c69cb40aba177bb2da3ce63439cc109eR108-R126'><strong>Visibility / UX change</strong></a><br>The stroke color control was made always visible by adding it to the color controls array. Verify that this is the intended UX for all Polygon use-cases and that the control's placement (after color breakpoints) yields expected grouping and behavior in the UI.<br> </td></tr> </table> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
