codeant-ai-for-open-source[bot] commented on PR #37018: URL: https://github.com/apache/superset/pull/37018#issuecomment-3732919316
## Nitpicks 🔍 <table> <tr><td>🔒 <strong>No security issues identified</strong></td></tr> <tr><td>⚡ <strong>Recommended areas for review</strong><br><br> - [ ] <a href='https://github.com/apache/superset/pull/37018/files#diff-bc7e53e33b596b09ac892d36b7ef7a830a19f197ac7426ba73852a094521c5d3R617-R621'><strong>Potential filter staleness</strong></a><br>The PR also skips `onFiltersRefresh()` for lazy loads. Make sure this will not leave filter state inconsistent when nested tab charts are refreshed lazily — verify that filters remain correct and that UI doesn't show inconsistent data when `onFiltersRefresh` is suppressed.<br> - [ ] <a href='https://github.com/apache/superset/pull/37018/files#diff-bc7e53e33b596b09ac892d36b7ef7a830a19f197ac7426ba73852a094521c5d3R607-R620'><strong>Reducer / side-effect changes</strong></a><br>Skipping the `ON_REFRESH` action and `onFiltersRefresh()` for lazy loads may prevent reducers or middleware from running logic previously tied to that action (for example, global refresh time updates, metrics, or other side effects). Audit reducers and middleware listening for `ON_REFRESH` or `ON_FILTERS_REFRESH` to ensure skipping them for lazy loads doesn't produce stale state or missed telemetry.<br> - [ ] <a href='https://github.com/apache/superset/pull/37018/files#diff-bc7e53e33b596b09ac892d36b7ef7a830a19f197ac7426ba73852a094521c5d3R601-R606'><strong>Callsite compatibility</strong></a><br>The new `isLazyLoad` parameter changes the semantics of `onRefresh`. Consumers that need lazy refresh behavior must pass `true`; otherwise behavior remains unchanged due to the default. Verify all call sites (including extensions and presets) that trigger refreshes for nested tabs or lazy-loaded components are updated to pass the flag where appropriate. If any callers dispatch `onRefresh` indirectly (e.g., via wrapper actions), confirm they propagate the new parameter.<br> </td></tr> </table> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
