codeant-ai-for-open-source[bot] commented on PR #37041: URL: https://github.com/apache/superset/pull/37041#issuecomment-3737027182
## Nitpicks 🔍 <table> <tr><td>🔒 <strong>No security issues identified</strong></td></tr> <tr><td>⚡ <strong>Recommended areas for review</strong><br><br> - [ ] <a href='https://github.com/apache/superset/pull/37041/files#diff-f5e105394d3ba7e10b0f5d554581b1cdb43c1b05cb30c419b42cc1563faa9769R36-R41'><strong>Timezone parsing assumption</strong></a><br>The code calls extendedDayjs.utc(queriedDttm).local() which assumes the incoming timestamp should be interpreted as UTC. If the source timestamp already includes timezone info or is in local time, this can yield incorrect displayed values. Confirm the origin/timezone of queriedDttm and centralize parsing logic.<br> - [ ] <a href='https://github.com/apache/superset/pull/37041/files#diff-f5e105394d3ba7e10b0f5d554581b1cdb43c1b05cb30c419b42cc1563faa9769R53-R53'><strong>i18n string concatenation</strong></a><br>The UI builds the displayed label by translating the static text and concatenating the formatted time outside the translation: {t('Last queried at')}: {formattedTime}. This breaks languages where word order or punctuation differs and prevents translators from handling placement/formatting of the timestamp. Use a single translatable string with interpolation for the whole message.<br> </td></tr> </table> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
