richardfogaca commented on code in PR #36416:
URL: https://github.com/apache/superset/pull/36416#discussion_r2683103861
##########
superset-frontend/src/components/Datasource/components/DatasourceEditor/DatasourceEditor.jsx:
##########
@@ -157,6 +159,47 @@ const StyledTableTabWrapper = styled.div`
}
`;
+const DefaultColumnSettingsContainer = styled.div`
+ ${({ theme }) => css`
+ margin-bottom: ${theme.sizeUnit * 4}px;
+ `}
+`;
+
+const DefaultColumnSettingsTitle = styled.h4`
+ ${({ theme }) => css`
+ margin: 0 0 ${theme.sizeUnit * 2}px 0;
+ font-size: ${theme.fontSizeLG}px;
+ font-weight: ${theme.fontWeightMedium};
+ color: ${theme.colorText};
+ `}
+`;
+
+const DefaultColumnSettingsFields = styled.div`
+ ${({ theme }) => css`
+ display: flex;
+ flex-direction: column;
+ gap: ${theme.sizeUnit * 3}px;
+ `}
+`;
+
+const FieldWrapper = styled.div`
+ ${({ theme }) => css`
+ display: flex;
+ flex-direction: column;
+ gap: ${theme.sizeUnit}px;
+ `}
+`;
+
+const FieldLabelWithTooltip = styled.div`
+ ${({ theme }) => css`
+ display: flex;
+ align-items: center;
+ gap: ${theme.sizeUnit}px;
+ font-size: ${theme.fontSizeSM}px;
+ color: ${theme.colorTextLabel};
+ `}
+`;
Review Comment:
Good catch! I'll update it to use the Flex component for the pure layout
containers (DefaultColumnSettingsFields and FieldWrapper). Keeping
FieldLabelWithTooltip as a styled component since it has font styling beyond
flex layout
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
