Abhishekmishra2808 commented on PR #37037: URL: https://github.com/apache/superset/pull/37037#issuecomment-3740032220
@rusackas Good question. For this change, adding an automated test that validates the resulting PDF dimensions would be quite heavy, since PDF rendering depends on the reporting worker and headless browser setup, which is not trivial to assert reliably in tests. This PR is intentionally scoped to the frontend visibility issue only. The backend already applies `screenshot_width` correctly for PDF exports, as demonstrated by the existing workaround (setting the width in PNG mode and switching to PDF). If useful, I can add a lightweight frontend test to ensure the width field is displayed for both PNG and PDF formats to prevent regressions on the UI side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
