codeant-ai-for-open-source[bot] commented on PR #37068: URL: https://github.com/apache/superset/pull/37068#issuecomment-3741539022
## Nitpicks 🔍 <table> <tr><td>🔒 <strong>No security issues identified</strong></td></tr> <tr><td>⚡ <strong>Recommended areas for review</strong><br><br> - [ ] <a href='https://github.com/apache/superset/pull/37068/files#diff-85d1bd0b713d3e76cb60a456cb21de5968080a297a4e9a111b4eeb50cebadf21R359-R365'><strong>Possible Bug</strong></a><br>The code always pushes a drill filter even if neither `formData.granularitySqla` nor `formData.xAxis` is defined (or is an empty value). This can create an invalid filter object (missing `col`) that may break downstream drill handling. Also using `||` will treat empty strings or other falsy-but-intentional values as missing.<br> - [ ] <a href='https://github.com/apache/superset/pull/37068/files#diff-85d1bd0b713d3e76cb60a456cb21de5968080a297a4e9a111b4eeb50cebadf21R360-R363'><strong>Data mismatch</strong></a><br>`grain: formData?.timeGrainSqla` is always included in the filter even when the chosen `col` comes from `formData.xAxis` (which may be non-temporal). Applying a time grain to a non-temporal column may be incorrect and cause unexpected drill-to-detail behavior.<br> </td></tr> </table> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
