codeant-ai-for-open-source[bot] commented on PR #37071: URL: https://github.com/apache/superset/pull/37071#issuecomment-3742206882
## Nitpicks 🔍 <table> <tr><td>🔒 <strong>No security issues identified</strong></td></tr> <tr><td>⚡ <strong>Recommended areas for review</strong><br><br> - [ ] <a href='https://github.com/apache/superset/pull/37071/files#diff-19000690c3c900b1f69f03531af76a171cf9d4cfb834b25a1aea8c4e993cfd4eR54-R64'><strong>Large integers not detected</strong></a><br>The helper `_convert_big_integers` only checks for built-in `int`. NumPy integer types (e.g., `numpy.int64`) or other integer-like types returned by pandas may not be recognized and therefore won't be stringified when exceeding `JS_MAX_INTEGER`, which can lead to numeric precision loss or incorrect behavior in JS consumers.<br> - [ ] <a href='https://github.com/apache/superset/pull/37071/files#diff-19000690c3c900b1f69f03531af76a171cf9d4cfb834b25a1aea8c4e993cfd4eR56-R63'><strong>Infinity values not handled</strong></a><br>The new NaN-to-None logic uses `pd.isna` which covers NaN/NA/NaT, but does not cover positive/negative infinity (`inf`, `-inf`). Such values are also not valid JSON numbers and should be normalized (e.g., to `None` or a safe string) before serialization.<br> - [ ] <a href='https://github.com/apache/superset/pull/37071/files#diff-19000690c3c900b1f69f03531af76a171cf9d4cfb834b25a1aea8c4e993cfd4eR54-R64'><strong>Potential type coercion needed</strong></a><br>Values coming from `dframe.to_dict(orient="records")` may include numpy scalars (e.g., `numpy.float64`, `numpy.int64`) and pandas extension scalars. The code currently treats values as plain Python types which may leave numpy scalars as-is; consider normalizing to native Python types when appropriate to ensure consistent downstream JSON serialization and `isinstance` checks behave as expected.<br> </td></tr> </table> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
