codeant-ai-for-open-source[bot] commented on PR #37111:
URL: https://github.com/apache/superset/pull/37111#issuecomment-3747298903
## **Sequence Diagram**
The PR ensures totals queries with no dimension columns (columns=[]) don't
attempt to build a datetime join key from a numeric metric. Instead the join
logic falls back to the temporary-key (__temp_join_key__) join so offset totals
correctly merge into the totals row.
```mermaid
sequenceDiagram
participant TimeOffsetProcessor
participant _determine_join_keys
participant _perform_join
participant MainDF
participant OffsetDF
TimeOffsetProcessor->>_determine_join_keys: Determine join keys for
totals query (join_keys = [])
_determine_join_keys->>_determine_join_keys: If no join keys and first
column is NOT datetime -> return empty keys
TimeOffsetProcessor->>_perform_join: Call perform join with
actual_join_keys = []
_perform_join->>MainDF: add __temp_join_key__ = 1
_perform_join->>OffsetDF: add __temp_join_key__ = 1 and left-join on it
_perform_join->>TimeOffsetProcessor: remove temp keys and return merged
DF
```
---
*Generated by [CodeAnt AI](https://codeant.ai)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
