bito-code-review[bot] commented on PR #37065:
URL: https://github.com/apache/superset/pull/37065#issuecomment-3751776061
<!-- Bito Reply -->
The suggestion is valid—it improves maintainability and consistency by using
the imported DASHBOARD_ROOT_ID constant instead of the literal 'ROOT_ID' string
in the test, matching the implementation's approach.
**superset-frontend/src/dashboard/components/nativeFilters/state.test.ts**
```
import { DASHBOARD_ROOT_ID } from '../../util/constants';
// In the test:
scope: { rootPath: [DASHBOARD_ROOT_ID], excluded: [] },
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
