bito-code-review[bot] commented on code in PR #37107:
URL: https://github.com/apache/superset/pull/37107#discussion_r2693392623
##########
superset-frontend/src/components/Chart/ChartRenderer.tsx:
##########
@@ -400,9 +538,10 @@ class ChartRenderer extends Component {
formData={currentFormData}
ownState={ownState}
filterState={filterState}
- hooks={this.hooks}
+ // eslint-disable-next-line @typescript-eslint/no-explicit-any
+ hooks={this.hooks as any}
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Type Safety Violation</b></div>
<div id="fix">
Using 'as any' bypasses TypeScript type checking, violating project rules
against 'any' types. The ChartHooks interface has an incompatible onAddFilter
signature compared to the expected Hooks type. Consider updating ChartHooks to
extend Hooks for type safety.
</div>
</div>
<details>
<summary><b>Citations</b></summary>
<ul>
<li>
Rule Violated: <a
href="https://github.com/apache/superset/blob/8edb520/.cursor/rules/dev-standard.mdc#L16";>dev-standard.mdc:16</a>
</li>
<li>
Rule Violated: <a
href="https://github.com/apache/superset/blob/8edb520/AGENTS.md#L57";>AGENTS.md:57</a>
</li>
</ul>
</details>
<small><i>Code Review Run #c5f1c8</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
