massucattoj opened a new pull request, #37164:
URL: https://github.com/apache/superset/pull/37164

   …r events at same timestamp
   
   <!---
   Please write the PR title following the conventions at 
https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   Refactors `transformIntervalAnnotation` and `transformEventAnnotation` in 
the ECharts Timeseries plugin to group annotations that share the same 
timestamp.
   
     **Problem**: When multiple event or interval annotations had the same 
start time, each annotation created its own series, resulting in overlapping 
labels and visual clutter.
   
     **Solution**: Annotations at the same timestamp are now combined into a 
single series with their labels joined by newlines. This produces cleaner 
rendering and better performance by reducing the number of series created.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   BEFORE:
   <img width="1440" height="662" alt="image" 
src="https://github.com/user-attachments/assets/84056d48-8661-4f4b-abb6-b4d98a8a5c46";
 />
   
   <img width="1440" height="710" alt="image" 
src="https://github.com/user-attachments/assets/f9826694-23da-4dd5-8ad6-f360fde2ae47";
 />
   
   AFTER:
   <img width="1587" height="534" alt="Screenshot 2026-01-15 at 06 51 31" 
src="https://github.com/user-attachments/assets/bceb1af1-b831-4009-a731-cecfb0cb10cb";
 />
   
   <img width="1257" height="739" alt="Screenshot 2026-01-15 at 06 51 53" 
src="https://github.com/user-attachments/assets/789a99f3-31d8-45f3-88bf-de4df303a037";
 />
   
   
   ### TESTING INSTRUCTIONS
   
   1. Create a table chart following the instructions 
[here](https://docs.preset.io/docs/annotations#:~:text=Create%20and%20manage%20time%20annotations%20with%20Google%20Sheet)
 (you can use a Google Sheet for this). You can also use [this Google 
sheet](https://docs.google.com/spreadsheets/d/1Emqv5eO9gRd3j66524tkH_AVHujdmzw4d_DSKjAX_Uc/edit?usp=sharing).
   2. Then, create a Line chart and add a new annotation layer on it
   3. After this, you select the Annotation Layer type, Interval or Event
   4. Then the annotation source Table
   5. As the next step, you select the table chart you created in step
   6. This reloads the annotation windows to show the specific options 
associated with the table
   7. Define the Interval start column/Event time column by using the 
start_date column that has the table chart
   8. Add the annotation by clicking on the Apply button
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to