reynoldmorel commented on code in PR #36963:
URL: https://github.com/apache/superset/pull/36963#discussion_r2694367941
##########
superset-frontend/packages/superset-ui-core/src/components/Select/Select.tsx:
##########
@@ -776,6 +777,7 @@ const Select = forwardRef(
optionRender={option => <Space>{option.label ||
option.value}</Space>}
oneLine={oneLine}
css={props.css}
+ dropdownAlign={DROPDOWN_ALIGN_BOTTOM}
Review Comment:
I’m concerned that a unit test here would be largely meaningless, at least
in the form I can currently imagine. For example, we could spy on or mock the
component and assert that dropdownAlign is passed with a specific value, but
that feels brittle—those props could change or even be removed in certain
scenarios and still be perfectly valid.
The real issue we’re trying to prevent is the dropdown popup overlapping or
extending beyond the input when the container shrinks. That behavior isn’t well
captured by asserting internal props.
Given that, a visual test seems more appropriate in this case. We can
reasonably assume AntD’s dropdown props behave as intended, and focus on
validating the actual user-facing behavior instead.
What do you think @gabotorresruiz
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
