dheeraj12347 commented on issue #37096: URL: https://github.com/apache/superset/issues/37096#issuecomment-3755308657
Hi @martinburch and team! 👋 I'd like to work on this issue. After reading the discussion, I understand that: 1. The default font stack needs `sans-serif` added as a fallback 2. Font management has moved from `config.py` to **theme configuration** (not config.py) 3. The fix should be in theme token files, likely updating `fontFamily` to include `sans-serif` **My plan:** 1. Locate the default theme configuration files in the codebase 2. Find the current `fontFamily` definition 3. Add `sans-serif` as a fallback: `"Inter, Helvetica, Arial, sans-serif"` 4. Test on different browsers (especially Firefox) to ensure fallback works 5. Submit a PR with before/after screenshots **Before I fork the repo, could you clarify:** - Where exactly is the default theme configuration stored? (e.g., `superset/assets/theme.json`, or in `config.py`?) - Should I also update any other theme-related files? - Are there any theme files for different UI modes (light/dark)? Thanks! Happy to get started once I have clarity. 😊 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
