ompharate commented on PR #36330: URL: https://github.com/apache/superset/pull/36330#issuecomment-3755922359
Thanks for the feedback @sadpandajoe! I've addressed both issues - Removed the hardcoded `iconColor` prop. Icons now inherit colors from the Button's CSS, automatically supporting all button states. - Setting `placement = 'bottomRight'` as the default changed the original behavior where no placement was specified (which uses Ant Design's bottomLeft default) <img width="864" height="748" alt="Screenshot 2026-01-15 at 10 27 06 PM" src="https://github.com/user-attachments/assets/a0f39513-fd79-43a6-8ea2-3e2e604d549d"; /> <img width="909" height="839" alt="Screenshot 2026-01-15 at 10 27 25 PM" src="https://github.com/user-attachments/assets/aa2bb609-5501-44de-9d16-c839ddaa302f"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
