richardfogaca commented on code in PR #36416:
URL: https://github.com/apache/superset/pull/36416#discussion_r2695757979
##########
superset/viz.py:
##########
@@ -475,6 +480,56 @@ def cache_key(self, query_obj: QueryObjectDict, **extra:
Any) -> str:
json_data = self.json_dumps(cache_dict, sort_keys=True)
return hash_from_str(json_data)
+ @deprecated(deprecated_in="3.0")
Review Comment:
Good point @betodealmeida . Looking at the legacy charts that still use
viz.py (NVD3, Deck.GL, geo maps, etc.), none of them would realistically use
currency formatting. The charts that actually support currency (Table, Pivot
Table, Big Number, Pie, Timeseries) all use the modern Chart Data API path
where detection is already implemented in query_actions.py.
I'll remove the _detect_currency method from viz.py since it's not needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
