geido commented on code in PR #37022:
URL: https://github.com/apache/superset/pull/37022#discussion_r2698238811
##########
superset-frontend/plugins/plugin-chart-echarts/src/utils/tooltip.ts:
##########
@@ -27,12 +27,21 @@ import {
import { TOOLTIP_OVERFLOW_MARGIN, TOOLTIP_POINTER_MARGIN } from '../constants';
import { Refs } from '../types';
+const TOOLTIP_Z_INDEX = 3010;
+
export function getDefaultTooltip(refs: Refs) {
return {
appendToBody: true,
borderColor: 'transparent',
// CSS hack applied on this class to resolve
https://github.com/apache/superset/issues/30058
className: 'echarts-tooltip',
+ // allow scrolling inside tooltip without re-triggering the chart
+ enterable: true,
+ // keep within viewport and above header; enable internal scroll
+ confine: true,
+ extraCssText: `max-height:80vh; overflow:auto;
-webkit-overflow-scrolling:touch; pointer-events:auto;
z-index:${TOOLTIP_Z_INDEX};`,
Review Comment:
Let's have a look at the calculations that it's doing below to see if there
is a way to avoid inline styles here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
