gabotorresruiz commented on code in PR #36996:
URL: https://github.com/apache/superset/pull/36996#discussion_r2698901749
##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterControls.tsx:
##########
@@ -659,12 +659,25 @@ const FilterControls: FC<FilterControlsProps> = ({
overflowedFiltersInScope.map(({ id }) => id),
);
- return filtersWithValues.map(
- filter =>
+ return filtersWithValues.map(filter => {
Review Comment:
I think we can simplify this to:
```js
return filtersWithValues.map(filter => {
// Out-of-scope filters in vertical mode are in a Collapse panel, not
overflowed
if (filtersOutOfScopeIds.has(filter.id)) {
return filterBarOrientation === FilterBarOrientation.Horizontal;
}
return overflowedFiltersInScopeIds.has(filter.id);
});
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
