bito-code-review[bot] commented on code in PR #36963:
URL: https://github.com/apache/superset/pull/36963#discussion_r2699840632
##########
superset-frontend/src/explore/components/SaveModal.tsx:
##########
@@ -332,6 +487,101 @@ class SaveModal extends Component<SaveModalProps,
SaveModalState> {
totalCount: count,
};
};
+ // Loads dashboard tabs and returns the tab hierarchy for display.
+ loadTabs = async (dashboardId: number) => {
+ try {
+ const response = await SupersetClient.get({
+ endpoint: `/api/v1/dashboard/${dashboardId}/tabs`,
+ });
+
+ const { result } = response.json;
+ if (!result || !Array.isArray(result.tab_tree)) {
+ logging.warn('Invalid tabs response format');
+ this.setState({ tabsData: [] });
+ return [];
+ }
+ const tabTree = result.tab_tree;
+ const gridTabIds = new Set<string>();
+ const convertToTreeData = (nodes: TabNode[]): TabTreeNode[] =>
+ nodes.map(node => {
+ const isGridTab =
+ Array.isArray(node.parents) && node.parents.includes('GRID_ID');
+ if (isGridTab) {
+ gridTabIds.add(node.value);
+ }
+ return {
+ value: node.value,
+ title: node.title,
+ key: node.value,
+ children:
+ node.children && node.children.length > 0
+ ? convertToTreeData(node.children)
+ : undefined,
+ };
+ });
+
+ const treeData = convertToTreeData(tabTree);
+
+ // Add "Out of tab" option at the beginning
+ if (gridTabIds.size > 0) {
+ const tabsDataWithOutOfTab = [
+ {
+ value: 'OUT_OF_TAB',
+ title: 'Out of tab',
+ key: 'OUT_OF_TAB',
+ children: undefined,
+ },
+ ...treeData,
+ ];
+
+ this.setState({
+ tabsData: tabsDataWithOutOfTab,
+ selectedTab: { value: 'OUT_OF_TAB', label: 'Out of tab' },
+ });
+ } else {
+ const firstTab = treeData[0];
+ this.setState({
+ tabsData: treeData,
+ selectedTab: { value: firstTab.value, label: firstTab.title },
+ });
+ }
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Potential undefined access</b></div>
<div id="fix">
Accessing treeData[0] without checking if treeData is empty can lead to
undefined errors when no tabs exist.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
````suggestion
} else {
if (treeData.length > 0) {
const firstTab = treeData[0];
this.setState({
tabsData: treeData,
selectedTab: { value: firstTab.value, label: firstTab.title },
});
}
}
````
</div>
</details>
</div>
<details>
<summary><b>Citations</b></summary>
<ul>
<li>
Rule Violated: <a
href="https://github.com/apache/superset/blob/82389c6/.cursor/rules/dev-standard.mdc#L16";>dev-standard.mdc:16</a>
</li>
</ul>
</details>
<small><i>Code Review Run #6c57cd</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
