VanessaGiannoni opened a new pull request, #37253: URL: https://github.com/apache/superset/pull/37253
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> - Fixes a regression where saving edits to one native filter clears all applied filters on the dashboard. - Adjusts reducer logic to only reset the edited filter(s) and preserve other filters’ data masks. - Adds type-safe unit tests using top-level test() (no describe), aligning with current testing guidelines. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> #### After  #### Before  ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> **Manual** 1. Open a dashboard with native filters. 2. Apply two filters (A and B) so both affect charts. 3. Edit filter A in the Native Filters modal, change its column/target, and save. 4. Verify: a. Filter A resets (cleared). b. Filter B remains applied. 5. Optional: Edit a filter without changing targets and with enableEmptyFilter or defaultToFirstItem set → state is preserved. **Automated** Frontend unit tests: ```bash npm run test -- src/dataMask/reducer.test.ts -w=1 ``` ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
