Antonio-RiveroMartnez commented on code in PR #37216:
URL: https://github.com/apache/superset/pull/37216#discussion_r2702251019
##########
superset/mcp_service/auth.py:
##########
@@ -127,14 +127,22 @@ def has_dataset_access(dataset: "SqlaTable") -> bool:
return False # Deny access on error
-def _setup_user_context() -> User:
+def _setup_user_context() -> User | None:
"""
Set up user context for MCP tool execution.
Returns:
- User object with roles and groups loaded
+ User object with roles and groups loaded, or None if no Flask context
"""
- user = get_user_from_request()
+ try:
+ user = get_user_from_request()
+ except RuntimeError as e:
+ # No Flask application context (e.g., prompts before middleware runs)
+ # This is expected for some FastMCP operations - return None gracefully
+ if "application context" in str(e):
Review Comment:
Cannot we catch the exact exception class being returned or is it just a
RuntimeError with a message?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
