dirivasm commented on PR #35349: URL: https://github.com/apache/superset/pull/35349#issuecomment-3769746092
> **Test Execution** > > Everything is working as expected, the only comment I have is that for this AC > > > If there's a specific token/key that isn't working, try to use the rest of the user's theme if we can. Just skip that one item. Show a toast to the admins only on load that there's an error: Theme token [name] in [theme name] was unable to be loaded. Visit the Themes page to fix it. > > So this is working fine, we use now the rest of the user's theme when there is key not working or invalid! BUT we are not displaying the expected error message!! > > Is this expected? **Update** - A new ticket has been created to address the missing error message! This ticket is QA Approved ✅ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
