bito-code-review[bot] commented on code in PR #37272:
URL: https://github.com/apache/superset/pull/37272#discussion_r2707066239
##########
docs/yarn.lock:
##########
@@ -4447,100 +4447,100 @@
dependencies:
"@types/yargs-parser" "*"
-"@typescript-eslint/[email protected]",
"@typescript-eslint/eslint-plugin@^8.52.0":
- version "8.53.0"
- resolved
"https://registry.yarnpkg.com/@typescript-eslint/eslint-plugin/-/eslint-plugin-8.53.0.tgz#afb966c66a2fdc6158cf81118204a971a36d0fc5";
- integrity
sha512-eEXsVvLPu8Z4PkFibtuFJLJOTAV/nPdgtSjkGoPpddpFk3/ym2oy97jynY6ic2m6+nc5M8SE1e9v/mHKsulcJg==
+"@typescript-eslint/[email protected]",
"@typescript-eslint/eslint-plugin@^8.52.0":
+ version "8.53.1"
+ resolved
"https://registry.yarnpkg.com/@typescript-eslint/eslint-plugin/-/eslint-plugin-8.53.1.tgz#f6640f6f8749b71d9ab457263939e8932a3c6b46";
+ integrity
sha512-cFYYFZ+oQFi6hUnBTbLRXfTJiaQtYE3t4O692agbBl+2Zy+eqSKWtPjhPXJu1G7j4RLjKgeJPDdq3EqOwmX5Ag==
dependencies:
"@eslint-community/regexpp" "^4.12.2"
- "@typescript-eslint/scope-manager" "8.53.0"
- "@typescript-eslint/type-utils" "8.53.0"
- "@typescript-eslint/utils" "8.53.0"
- "@typescript-eslint/visitor-keys" "8.53.0"
+ "@typescript-eslint/scope-manager" "8.53.1"
+ "@typescript-eslint/type-utils" "8.53.1"
+ "@typescript-eslint/utils" "8.53.1"
+ "@typescript-eslint/visitor-keys" "8.53.1"
ignore "^7.0.5"
natural-compare "^1.4.0"
ts-api-utils "^2.4.0"
-"@typescript-eslint/[email protected]", "@typescript-eslint/parser@^8.52.0":
- version "8.53.0"
- resolved
"https://registry.yarnpkg.com/@typescript-eslint/parser/-/parser-8.53.0.tgz#d8bed6f12dc74e03751e5f947510ff2b165990c6";
- integrity
sha512-npiaib8XzbjtzS2N4HlqPvlpxpmZ14FjSJrteZpPxGUaYPlvhzlzUZ4mZyABo0EFrOWnvyd0Xxroq//hKhtAWg==
+"@typescript-eslint/[email protected]", "@typescript-eslint/parser@^8.52.0":
+ version "8.53.1"
+ resolved
"https://registry.yarnpkg.com/@typescript-eslint/parser/-/parser-8.53.1.tgz#58d4a70cc2daee2becf7d4521d65ea1782d6ec68";
+ integrity
sha512-nm3cvFN9SqZGXjmw5bZ6cGmvJSyJPn0wU9gHAZZHDnZl2wF9PhHv78Xf06E0MaNk4zLVHL8hb2/c32XvyJOLQg==
dependencies:
- "@typescript-eslint/scope-manager" "8.53.0"
- "@typescript-eslint/types" "8.53.0"
- "@typescript-eslint/typescript-estree" "8.53.0"
- "@typescript-eslint/visitor-keys" "8.53.0"
+ "@typescript-eslint/scope-manager" "8.53.1"
+ "@typescript-eslint/types" "8.53.1"
+ "@typescript-eslint/typescript-estree" "8.53.1"
+ "@typescript-eslint/visitor-keys" "8.53.1"
debug "^4.4.3"
-"@typescript-eslint/[email protected]":
- version "8.53.0"
- resolved
"https://registry.yarnpkg.com/@typescript-eslint/project-service/-/project-service-8.53.0.tgz#327c67c61c16a1c8b12a440b0779b41eb77cc7df";
- integrity
sha512-Bl6Gdr7NqkqIP5yP9z1JU///Nmes4Eose6L1HwpuVHwScgDPPuEWbUVhvlZmb8hy0vX9syLk5EGNL700WcBlbg==
+"@typescript-eslint/[email protected]":
+ version "8.53.1"
+ resolved
"https://registry.yarnpkg.com/@typescript-eslint/project-service/-/project-service-8.53.1.tgz#4e47856a0b14a1ceb28b0294b4badef3be1e9734";
+ integrity
sha512-WYC4FB5Ra0xidsmlPb+1SsnaSKPmS3gsjIARwbEkHkoWloQmuzcfypljaJcR78uyLA1h8sHdWWPHSLDI+MtNog==
dependencies:
- "@typescript-eslint/tsconfig-utils" "^8.53.0"
- "@typescript-eslint/types" "^8.53.0"
+ "@typescript-eslint/tsconfig-utils" "^8.53.1"
+ "@typescript-eslint/types" "^8.53.1"
debug "^4.4.3"
-"@typescript-eslint/[email protected]":
- version "8.53.0"
- resolved
"https://registry.yarnpkg.com/@typescript-eslint/scope-manager/-/scope-manager-8.53.0.tgz#f922fcbf0d42e72f065297af31779ccf19de9a97";
- integrity
sha512-kWNj3l01eOGSdVBnfAF2K1BTh06WS0Yet6JUgb9Cmkqaz3Jlu0fdVUjj9UI8gPidBWSMqDIglmEXifSgDT/D0g==
+"@typescript-eslint/[email protected]":
+ version "8.53.1"
+ resolved
"https://registry.yarnpkg.com/@typescript-eslint/scope-manager/-/scope-manager-8.53.1.tgz#6c4b8c82cd45ae3b365afc2373636e166743a8fa";
+ integrity
sha512-Lu23yw1uJMFY8cUeq7JlrizAgeQvWugNQzJp8C3x8Eo5Jw5Q2ykMdiiTB9vBVOOUBysMzmRRmUfwFrZuI2C4SQ==
dependencies:
- "@typescript-eslint/types" "8.53.0"
- "@typescript-eslint/visitor-keys" "8.53.0"
+ "@typescript-eslint/types" "8.53.1"
+ "@typescript-eslint/visitor-keys" "8.53.1"
-"@typescript-eslint/[email protected]",
"@typescript-eslint/tsconfig-utils@^8.53.0":
- version "8.53.0"
- resolved
"https://registry.yarnpkg.com/@typescript-eslint/tsconfig-utils/-/tsconfig-utils-8.53.0.tgz#105279d7969a7abdc8345cc9c57cff83cf910f8f";
- integrity
sha512-K6Sc0R5GIG6dNoPdOooQ+KtvT5KCKAvTcY8h2rIuul19vxH5OTQk7ArKkd4yTzkw66WnNY0kPPzzcmWA+XRmiA==
+"@typescript-eslint/[email protected]",
"@typescript-eslint/tsconfig-utils@^8.53.1":
+ version "8.53.1"
+ resolved
"https://registry.yarnpkg.com/@typescript-eslint/tsconfig-utils/-/tsconfig-utils-8.53.1.tgz#efe80b8d019cd49e5a1cf46c2eb0cd2733076424";
+ integrity
sha512-qfvLXS6F6b1y43pnf0pPbXJ+YoXIC7HKg0UGZ27uMIemKMKA6XH2DTxsEDdpdN29D+vHV07x/pnlPNVLhdhWiA==
-"@typescript-eslint/[email protected]":
- version "8.53.0"
- resolved
"https://registry.yarnpkg.com/@typescript-eslint/type-utils/-/type-utils-8.53.0.tgz#81a0de5c01fc68f6df0591d03cd8226bda01c91f";
- integrity
sha512-BBAUhlx7g4SmcLhn8cnbxoxtmS7hcq39xKCgiutL3oNx1TaIp+cny51s8ewnKMpVUKQUGb41RAUWZ9kxYdovuw==
+"@typescript-eslint/[email protected]":
+ version "8.53.1"
+ resolved
"https://registry.yarnpkg.com/@typescript-eslint/type-utils/-/type-utils-8.53.1.tgz#95de2651a96d580bf5c6c6089ddd694284d558ad";
+ integrity
sha512-MOrdtNvyhy0rHyv0ENzub1d4wQYKb2NmIqG7qEqPWFW7Mpy2jzFC3pQ2yKDvirZB7jypm5uGjF2Qqs6OIqu47w==
dependencies:
- "@typescript-eslint/types" "8.53.0"
- "@typescript-eslint/typescript-estree" "8.53.0"
- "@typescript-eslint/utils" "8.53.0"
+ "@typescript-eslint/types" "8.53.1"
+ "@typescript-eslint/typescript-estree" "8.53.1"
+ "@typescript-eslint/utils" "8.53.1"
debug "^4.4.3"
ts-api-utils "^2.4.0"
-"@typescript-eslint/[email protected]", "@typescript-eslint/types@^8.53.0":
- version "8.53.0"
- resolved
"https://registry.yarnpkg.com/@typescript-eslint/types/-/types-8.53.0.tgz#1adcad3fa32bc2c4cbf3785ba07a5e3151819efb";
- integrity
sha512-Bmh9KX31Vlxa13+PqPvt4RzKRN1XORYSLlAE+sO1i28NkisGbTtSLFVB3l7PWdHtR3E0mVMuC7JilWJ99m2HxQ==
+"@typescript-eslint/[email protected]", "@typescript-eslint/types@^8.53.1":
+ version "8.53.1"
+ resolved
"https://registry.yarnpkg.com/@typescript-eslint/types/-/types-8.53.1.tgz#101f203f0807a63216cceceedb815fabe21d5793";
+ integrity
sha512-jr/swrr2aRmUAUjW5/zQHbMaui//vQlsZcJKijZf3M26bnmLj8LyZUpj8/Rd6uzaek06OWsqdofN/Thenm5O8A==
-"@typescript-eslint/[email protected]":
- version "8.53.0"
- resolved
"https://registry.yarnpkg.com/@typescript-eslint/typescript-estree/-/typescript-estree-8.53.0.tgz#7805b46b7a8ce97e91b7bb56fc8b1ba26ca8ef52";
- integrity
sha512-pw0c0Gdo7Z4xOG987u3nJ8akL9093yEEKv8QTJ+Bhkghj1xyj8cgPaavlr9rq8h7+s6plUJ4QJYw2gCZodqmGw==
+"@typescript-eslint/[email protected]":
+ version "8.53.1"
+ resolved
"https://registry.yarnpkg.com/@typescript-eslint/typescript-estree/-/typescript-estree-8.53.1.tgz#b6dce2303c9e27e95b8dcd8c325868fff53e488f";
+ integrity
sha512-RGlVipGhQAG4GxV1s34O91cxQ/vWiHJTDHbXRr0li2q/BGg3RR/7NM8QDWgkEgrwQYCvmJV9ichIwyoKCQ+DTg==
dependencies:
- "@typescript-eslint/project-service" "8.53.0"
- "@typescript-eslint/tsconfig-utils" "8.53.0"
- "@typescript-eslint/types" "8.53.0"
- "@typescript-eslint/visitor-keys" "8.53.0"
+ "@typescript-eslint/project-service" "8.53.1"
+ "@typescript-eslint/tsconfig-utils" "8.53.1"
+ "@typescript-eslint/types" "8.53.1"
+ "@typescript-eslint/visitor-keys" "8.53.1"
debug "^4.4.3"
minimatch "^9.0.5"
semver "^7.7.3"
tinyglobby "^0.2.15"
ts-api-utils "^2.4.0"
-"@typescript-eslint/[email protected]":
- version "8.53.0"
- resolved
"https://registry.yarnpkg.com/@typescript-eslint/utils/-/utils-8.53.0.tgz#bf0a4e2edaf1afc9abce209fc02f8cab0b74af13";
- integrity
sha512-XDY4mXTez3Z1iRDI5mbRhH4DFSt46oaIFsLg+Zn97+sYrXACziXSQcSelMybnVZ5pa1P6xYkPr5cMJyunM1ZDA==
+"@typescript-eslint/[email protected]":
+ version "8.53.1"
+ resolved
"https://registry.yarnpkg.com/@typescript-eslint/utils/-/utils-8.53.1.tgz#81fe6c343de288701b774f4d078382f567e6edaa";
+ integrity
sha512-c4bMvGVWW4hv6JmDUEG7fSYlWOl3II2I4ylt0NM+seinYQlZMQIaKaXIIVJWt9Ofh6whrpM+EdDQXKXjNovvrg==
dependencies:
"@eslint-community/eslint-utils" "^4.9.1"
- "@typescript-eslint/scope-manager" "8.53.0"
- "@typescript-eslint/types" "8.53.0"
- "@typescript-eslint/typescript-estree" "8.53.0"
+ "@typescript-eslint/scope-manager" "8.53.1"
+ "@typescript-eslint/types" "8.53.1"
+ "@typescript-eslint/typescript-estree" "8.53.1"
-"@typescript-eslint/[email protected]":
- version "8.53.0"
- resolved
"https://registry.yarnpkg.com/@typescript-eslint/visitor-keys/-/visitor-keys-8.53.0.tgz#9a785664ddae7e3f7e570ad8166e48dbc9c6cf02";
- integrity
sha512-LZ2NqIHFhvFwxG0qZeLL9DvdNAHPGCY5dIRwBhyYeU+LfLhcStE1ImjsuTG/WaVh3XysGaeLW8Rqq7cGkPCFvw==
+"@typescript-eslint/[email protected]":
+ version "8.53.1"
+ resolved
"https://registry.yarnpkg.com/@typescript-eslint/visitor-keys/-/visitor-keys-8.53.1.tgz#405f04959be22b9be364939af8ac19c3649b6eb7";
+ integrity
sha512-oy+wV7xDKFPRyNggmXuZQSBzvoLnpmJs+GhzRhPjrxl2b/jIlyjVokzm47CZCDUdXKr2zd7ZLodPfOBpOPyPlg==
dependencies:
- "@typescript-eslint/types" "8.53.0"
+ "@typescript-eslint/types" "8.53.1"
eslint-visitor-keys "^4.2.1"
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Invalid dependency version</b></div>
<div id="fix">
The lock file updates to version 8.53.1, but this version does not exist per
official @typescript-eslint releases. Latest is 8.53.0, which is allowed by
package.json ^8.52.0. Using invalid version risks yarn install failures.
</div>
</div>
<small><i>Code Review Run #4d2f12</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
