Bhumi0189 commented on code in PR #37262:
URL: https://github.com/apache/superset/pull/37262#discussion_r2707591737
##########
superset-frontend/src/dashboard/util/getDetailedComponentWidth.ts:
##########
@@ -77,9 +95,9 @@ export default function getDetailedComponentWidth({
result.occupiedWidth = 0;
(component.children || []).forEach(childId => {
// rows don't have widths, so find the width of its children
- if (components[childId].type === ROW_TYPE) {
+ if (components[childId]?.type === ROW_TYPE) {
result.minimumWidth = Math.max(
- result.minimumWidth,
+ result.minimumWidth ?? GRID_MIN_COLUMN_COUNT,
getTotalChildWidth({ id: childId, components }),
Review Comment:
Thanks for catching this 👍
I’ve updated the COLUMN_TYPE logic to compute and store the maximum child
width in `result.occupiedWidth`, aligning behavior with the existing comment
and intended aggregation logic.
Fix pushed in the latest commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
