bito-code-review[bot] commented on code in PR #37255:
URL: https://github.com/apache/superset/pull/37255#discussion_r2708389278
##########
superset-frontend/src/SqlLab/components/ResultSet/index.tsx:
##########
@@ -728,45 +675,58 @@ const ResultSet = ({
return (
<>
<ResultContainer>
- {renderControls()}
- {showSql && showSqlInline ? (
- <>
- <div
- css={css`
- display: flex;
- justify-content: space-between;
- align-items: center;
- gap: ${GAP}px;
- `}
- >
- <Card
- css={[
- css`
- height: 28px;
- width: calc(100% - ${ROWS_CHIP_WIDTH + GAP}px);
- code {
- width: 100%;
- overflow: hidden;
- white-space: nowrap !important;
- text-overflow: ellipsis;
- display: block;
- }
- `,
- ]}
+ <div
+ css={css`
+ display: flex;
+ align-items: center;
+ gap: ${GAP}px;
+
+ & .ant-divider {
+ height: ${theme.sizeUnit * 6}px;
+ margin: 0 ${theme.sizeUnit * 2}px 0 0;
+ }
+ `}
+ >
+ {renderControls()}
+ <Divider type="vertical" />
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Incorrect Divider prop for antd v5</b></div>
<div id="fix">
The Divider components use 'type="vertical"', but Ant Design v5 requires
'orientation="vertical"' instead. This causes the dividers to render
horizontally instead of vertically, breaking the intended UI layout.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
- <Divider type="vertical" />
+ <Divider orientation="vertical" />
@@ -714,1 +714,1 @@
- <Divider type="vertical" />
+ <Divider orientation="vertical" />
```
</div>
</details>
</div>
<details>
<summary><b>Citations</b></summary>
<ul>
<li>
Rule Violated: <a
href="https://github.com/apache/superset/blob/19138e3/AGENTS.md#L12";>AGENTS.md:12</a>
</li>
</ul>
</details>
<small><i>Code Review Run #c6b6d3</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
