innovark37 opened a new pull request, #37287: URL: https://github.com/apache/superset/pull/37287
### SUMMARY This PR fixes an issue where SVG images in EmptyState components were being cropped at the edges, causing visual clipping and incomplete display of illustrations. #### Affected Images: - `empty.svg` - `empty-dashboard.svg` - `star-circle.svg` ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF BEFORE <img width="247" height="319" alt="image" src="https://github.com/user-attachments/assets/f2e96d59-75b4-47a4-8882-58a2b7bf8b20"; /> <img width="264" height="314" alt="{4D3D2EFB-198B-4FC0-9A4B-43488056B4B6}" src="https://github.com/user-attachments/assets/802b56c5-5f56-46c2-ae88-d905823d243c"; /> <img width="248" height="311" alt="{401F604D-A21F-4118-A8A4-C1BDB824705A}" src="https://github.com/user-attachments/assets/5b728f68-0ac5-4413-9b09-38e899a825b8"; /> AFTER <img width="241" height="308" alt="image" src="https://github.com/user-attachments/assets/7404f14f-5716-48d3-bd02-1666844480f1"; /> <img width="240" height="312" alt="image" src="https://github.com/user-attachments/assets/44950320-bc56-4f86-b471-7533c2fe03bd"; /> <img width="263" height="316" alt="image" src="https://github.com/user-attachments/assets/1f4381e5-dc2e-42a5-9900-0df2e9471630"; /> ### TESTING INSTRUCTIONS Before starting, ensure: - No dashboards exist in the system - No charts exist in the system - No saved queries exist in the system #### Test Steps 1. Test "Empty Dashboard" image (`empty-dashboard.svg`) 1.1. Navigate to Welcome page (/) 1.2. Locate the "Dashboards" section 1.3. Click the "Mine" tab 1.4. Verify the empty state illustration 1.5. Click the "All" tab 1.6. Verify the empty state illustration 2. Test "Star" image for Favorites (`star-circle.svg`) 2.1. Navigate to Welcome page (/) 2.2. Locate the "Dashboards" section 2.3. Click the "Favorite" tab 2.4. Verify the star illustration 2.5. Repeat in "Charts" section, "Favorite" tab 3. Test "Empty" image (`empty.svg`) 3.1. Navigate to Welcome page (/) 3.2. Locate the "Saved Queries" section 3.3. Click the "Mine" tab 3.4. Verify the empty state illustration ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
