bito-code-review[bot] commented on code in PR #37185:
URL: https://github.com/apache/superset/pull/37185#discussion_r2710930481
##########
superset/mcp_service/chart/chart_utils.py:
##########
@@ -92,8 +202,9 @@ def generate_explore_link(dataset_id: int | str, form_data:
Dict[str, Any]) -> s
# Return URL with just the form_data_key
return f"{base_url}/explore/?form_data_key={form_data_key}"
- except Exception:
+ except (CommandException, KeyError, ValueError) as e:
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Error Handling Risk</b></div>
<div id="fix">
The change from `except Exception` to specific exceptions may cause
unexpected errors to propagate instead of falling back to a basic explore URL,
potentially breaking callers.
</div>
</div>
<small><i>Code Review Run #e7e81b</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/mcp_service/chart/chart_utils.py:
##########
@@ -34,6 +37,113 @@
from superset.mcp_service.utils.url_utils import get_superset_base_url
from superset.utils import json
+logger = logging.getLogger(__name__)
+
+
+@dataclass
+class DatasetValidationResult:
+ """Result of dataset accessibility validation."""
+
+ is_valid: bool
+ dataset_id: int | None
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Type Annotation Fix</b></div>
<div id="fix">
The type for dataset_id should be `int | str | None` to accommodate UUID
datasets, as seen in generate_explore_link.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
````suggestion
dataset_id: int | str | None
````
</div>
</details>
</div>
<small><i>Code Review Run #e7e81b</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
