GitHub user dosubot[bot] added a comment to the discussion: Tooltips missing 
for dashboard view mode toggle icons (Grid/List) on Dashboard List page

<!-- Greeting -->
Hi @ionik0! I'm [Dosu](https://go.dosu.dev/dosubot) and I’m helping the 
superset team.

<!-- Answer -->
You're correct—there are currently no tooltips for the grid/list view toggle 
icons on the Dashboard List page. This is confirmed in the code: the toggle 
icons are rendered in the `ViewModeToggle` component inside 
`superset-frontend/src/components/ListView/ListView.tsx`, but they aren't 
wrapped in a Tooltip component or given a `title` attribute, so nothing appears 
on hover [see code 
reference](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset-frontend/src/components/ListView/ListView.tsx#L181-L513).

Other action icons on the Dashboard List page (like delete, export, and edit) 
do use the Superset Tooltip component, so adding tooltips for the view mode 
toggles would be consistent and improve both usability and accessibility [see 
usage](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset-frontend/src/pages/DashboardList/index.tsx#L19-L848).

To fix this, wrap each toggle icon in a `<Tooltip>` with the appropriate label 
("Grid view" and "List view") in the `ViewModeToggle` component. This will 
provide the expected hover text and align with accessibility best practices. 
There are no existing public PRs or issues that address this specific UI gap.


<!-- Dosu Comment Footer -->
*To reply, just mention [@dosu](https://go.dosu.dev/dosubot).*

---
<sup>How did I do? 
[Good](https://app.dosu.dev/response-feedback/675f5d0b-4eab-4cba-9a12-0c4c34c97bfc?feedback_type=great_response)
 | 
[Irrelevant](https://app.dosu.dev/response-feedback/675f5d0b-4eab-4cba-9a12-0c4c34c97bfc?feedback_type=irrelevant_answer)
 | 
[Incorrect](https://app.dosu.dev/response-feedback/675f5d0b-4eab-4cba-9a12-0c4c34c97bfc?feedback_type=incorrect_sources)
 | 
[Verbose](https://app.dosu.dev/response-feedback/675f5d0b-4eab-4cba-9a12-0c4c34c97bfc?feedback_type=too_verbose)
 | 
[Hallucination](https://app.dosu.dev/response-feedback/675f5d0b-4eab-4cba-9a12-0c4c34c97bfc?feedback_type=hallucination)
 | [Report 
🐛](https://app.dosu.dev/response-feedback/675f5d0b-4eab-4cba-9a12-0c4c34c97bfc?feedback_type=bug_report)
 | 
[Other](https://app.dosu.dev/response-feedback/675f5d0b-4eab-4cba-9a12-0c4c34c97bfc?feedback_type=other)</sup>

[![Chat with 
Dosu](https://dosu.dev/dosu-chat-badge.svg)](https://app.dosu.dev/a28d3c7e-a9d3-459e-9fb6-3a6f9ff4f357/ask?utm_source=github)&nbsp;[![Open
 in 
Cursor](https://dosu.dev/dosu-in-cursor.svg)](https://cursor.com/link/prompt?text=You%27re%20correct%E2%80%94there%20are%20currently%20no%20tooltips%20for%20the%20grid/list%20view%20toggle%20icons%20on%20the%20Dashboard%20List%20page.%20This%20is%20confirmed%20in%20the%20code%3A%20the%20toggle%20icons%20are%20rendered%20in%20the%20%60ViewModeToggle%60%20component%20inside%20%60superset-frontend/src/components/ListView/ListView.tsx%60%2C%20but%20they%20aren%27t%20wrapped%20in%20a%20Tooltip%20component%20or%20given%20a%20%60title%60%20attribute%2C%20so%20nothing%20appears%20on%20hover%C2%A0%5Bsee%20code%20reference%5D%28https%3A//github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset-frontend/src/components/ListView/ListView.tsx%23L181-L513%29.%0A%0AOther%20action%20icons%20on%20the%20Dashboard%20List%20pag
 
e%20%28like%20delete%2C%20export%2C%20and%20edit%29%20do%20use%20the%20Superset%20Tooltip%20component%2C%20so%20adding%20tooltips%20for%20the%20view%20mode%20toggles%20would%20be%20consistent%20and%20improve%20both%20usability%20and%20accessibility%C2%A0%5Bsee%20usage%5D%28https%3A//github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset-frontend/src/pages/DashboardList/index.tsx%23L19-L848%29.%0A%0ATo%20fix%20this%2C%20wrap%20each%20toggle%20icon%20in%20a%20%60%3CTooltip%3E%60%20with%20the%20appropriate%20label%20%28%22Grid%20view%22%20and%20%22List%20view%22%29%20in%20the%20%60ViewModeToggle%60%20component.%20This%20will%20provide%20the%20expected%20hover%20text%20and%20align%20with%20accessibility%20best%20practices.%20There%20are%20no%20existing%20public%20PRs%20or%20issues%20that%20address%20this%20specific%20UI%20gap.)&nbsp;[![Join
 
Discord](https://img.shields.io/badge/join-5865F2?logo=discord&logoColor=white&label=)](https://go.dosu.dev/discord-bot)&
 nbsp;[![Share on 
X](https://img.shields.io/badge/X-share-black)](https://twitter.com/intent/tweet?text=%40dosu_ai%20helped%20me%20solve%20this%20issue!&url=https%3A//github.com/apache/superset/discussions/37303)

GitHub link: 
https://github.com/apache/superset/discussions/37303#discussioncomment-15556851

----
This is an automatically sent email for [email protected].
To unsubscribe, please send an email to: 
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to