kasiazjc commented on PR #37298: URL: https://github.com/apache/superset/pull/37298#issuecomment-3780346356
@justinpark thank you for the PR! Some small initial thoughts below (@michael-s-molina will need your brain here too) **Top right corner schema picker ** <img width="468" height="438" alt="image" src="https://github.com/user-attachments/assets/54af15ca-88f5-4d45-8658-3e3e7b4bfdff"; /> I think the modal is an additional step and in a way harsh visual change that we can avoid by using dropdowns in the fields itself, so: - dataset field would just treigger a dropdown with databases list (searchable) - schema field would update based on the database selection (if no schema selected and user tries to run query we highlight it red or something like this) **Pinned/Preview tab** <img width="193" height="247" alt="image" src="https://github.com/user-attachments/assets/14b0f3c6-9670-4d53-9a89-5633778c6580"; /> - for consistency I think this should use "+folder" icon instead of list, so that user associate this tab with pinned schemas - instead of "see table schema" it could be "Pin and preview table schema", again for consistency Tell me what you think! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
