Copilot commented on code in PR #37220:
URL: https://github.com/apache/superset/pull/37220#discussion_r2713887435
##########
superset-frontend/webpack.config.js:
##########
@@ -466,6 +466,12 @@ const config = {
additionalCode: 'var module = module || {exports: {}};',
},
},
+ {
+ test: /node_modules\/(geostyler-style|geostyler-qgis-parser).*\.js$/,
Review Comment:
The regex pattern is overly permissive. The pattern
`/node_modules\/(geostyler-style|geostyler-qgis-parser).*\.js$/` will match any
path containing these package names anywhere in the directory structure,
including nested node_modules or files with these strings in their names.
Consider using a more specific pattern like
`/node_modules\/(geostyler-style|geostyler-qgis-parser)\/.*\.js$/` to only
match direct files within these packages.
```suggestion
test:
/node_modules\/(geostyler-style|geostyler-qgis-parser)\/.*\.js$/,
```
##########
superset-frontend/webpack.config.js:
##########
@@ -205,7 +205,7 @@ if (!isDevMode) {
new ForkTsCheckerWebpackPlugin({
async: false,
typescript: {
Review Comment:
The TypeScript memory limit is now doubled for local development (8192 MB)
compared to CI (4096 MB). This change should be documented in a comment to
clarify whether this is intentional. If this is meant to provide more resources
for local development, a comment explaining the reasoning would help future
maintainers understand the configuration.
```suggestion
typescript: {
// CI runs with the base TYPESCRIPT_MEMORY_LIMIT (e.g. 4096 MB) to
keep resource usage bounded,
// while local development is allowed double (e.g. 8192 MB) to
reduce type-check failures and
// improve developer experience on machines with more memory.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
