Copilot commented on code in PR #37295:
URL: https://github.com/apache/superset/pull/37295#discussion_r2713929647
##########
superset/security/manager.py:
##########
@@ -433,8 +433,9 @@ class SupersetSecurityManager( # pylint:
disable=too-many-public-methods
("can_time_range", "Api"),
("can_query_form_data", "Api"),
("can_query", "Api"),
- # CSS for dashboard styling
+ # CSS and themes for dashboard styling
("can_read", "CssTemplate"),
+ ("can_read", "Theme"),
Review Comment:
Consider adding a test assertion for the Theme permission in the existing
`test_public_role_permissions` method (e.g., `assert ("can_read", "Theme") in
public_perm_set`). This would ensure the Theme permission is explicitly
verified alongside CssTemplate and other styling-related permissions, providing
better regression protection for the fix in issue #37294.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
