bito-code-review[bot] commented on code in PR #37311:
URL: https://github.com/apache/superset/pull/37311#discussion_r2714587037
##########
tests/unit_tests/sql/transpile_to_dialect_test.py:
##########
@@ -345,3 +345,54 @@ def test_sqlglot_generation_error_raises_exception() ->
None:
match="Cannot transpile SQL to postgresql",
):
transpile_to_dialect("name = 'test'", "postgresql")
+
+
+# Tests for source_engine parameter
[email protected](
+ "sql,source_engine,target_engine,expected",
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Parametrize decorator expects tuple not string</b></div>
<div id="fix">
The first argument to `@pytest.mark.parametrize` should be a tuple of
parameter names, not a string. Change
`"sql,source_engine,target_engine,expected"` to `("sql", "source_engine",
"target_engine", "expected")`.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
````suggestion
@pytest.mark.parametrize(
("sql", "source_engine", "target_engine", "expected"),
````
</div>
</details>
</div>
<small><i>Code Review Run #aebbb4</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
