codeant-ai-for-open-source[bot] commented on code in PR #37304:
URL: https://github.com/apache/superset/pull/37304#discussion_r2715131968
##########
superset-frontend/src/components/ListView/ListView.tsx:
##########
@@ -197,32 +198,38 @@ const ViewModeToggle = ({
}: {
mode: 'table' | 'card';
setMode: (mode: 'table' | 'card') => void;
-}) => (
- <ViewModeContainer>
- <div
- role="button"
- tabIndex={0}
- onClick={e => {
- e.currentTarget.blur();
- setMode('card');
- }}
- className={cx('toggle-button', { active: mode === 'card' })}
- >
- <Icons.AppstoreOutlined iconSize="xl" />
- </div>
- <div
- role="button"
- tabIndex={0}
- onClick={e => {
- e.currentTarget.blur();
- setMode('table');
- }}
- className={cx('toggle-button', { active: mode === 'table' })}
- >
- <Icons.UnorderedListOutlined iconSize="xl" />
- </div>
- </ViewModeContainer>
-);
+}) => {
+ return (
+ <ViewModeContainer>
+ <Tooltip title={t('Grid view'}>
Review Comment:
**Suggestion:** The translation function call is missing a closing
parenthesis in the Tooltip title for the grid toggle, which will cause a
JSX/compile error and prevent the component from rendering; close the call so
it becomes t('Grid view'). [possible bug]
<details>
<summary><b>Severity Level:</b> Critical 🚨</summary>
```mdx
- ❌ Frontend dev server fails to compile.
- ❌ ListView component cannot render anywhere.
- ❌ CI frontend build step will fail.
```
</details>
```suggestion
<Tooltip title={t('Grid view')}>
```
<details>
<summary><b>Steps of Reproduction ✅ </b></summary>
```mdx
1. Open the file at superset-frontend/src/components/ListView/ListView.tsx
and locate the
Tooltip on the grid toggle around line 204 (`<Tooltip title={t('Grid
view'}>`).
2. Run the frontend build/dev server (e.g., from project root: `yarn dev` or
`yarn
build`). The TypeScript/JSX parser runs against ListView.tsx during bundling.
3. The JSX parser encounters the malformed expression `t('Grid view'}` at
ListView.tsx:204
and emits a compile/syntax error (unexpected token / unterminated call),
failing the build
step.
4. Because this is a compile-time syntax error, the app will not bundle and
the ListView
component (and any page importing it) cannot render. Note: the translation
function is
defined at
packages/superset-core/src/ui/translation/TranslatorSingleton.ts:66-68
(`function t(input: string, ...args: unknown[]) { ... }`), but the compile
failure occurs
before runtime translation is executed.
```
</details>
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/src/components/ListView/ListView.tsx
**Line:** 204:204
**Comment:**
*Possible Bug: The translation function call is missing a closing
parenthesis in the Tooltip title for the grid toggle, which will cause a
JSX/compile error and prevent the component from rendering; close the call so
it becomes t('Grid view').
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
