Vitor-Avila opened a new pull request, #37350:
URL: https://github.com/apache/superset/pull/37350

   ### SUMMARY
   This PR fixes different small issues affecting the OAuth2 flow:
   1. Implements `raise_for_status()` when getting/refreshing OAuth tokens, so 
that exceptions from the authorization server are properly logged.
   2. Properly loads `request_content_type` from 
`db_engine_spec.oauth2_token_request_type` for connections not defined via 
`DATABASE_OAUTH2_CLIENTS`.
   3. Properly loads `DATABASE_OAUTH2_REDIRECT_URI` from `config` when 
available.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   N/A
   
   ### TESTING INSTRUCTIONS
   1. Check that Bad Request errors when getting an OAuth2 token are logged.
   2. Test that setting up a `request_content_type` value for a DB Engine Spec 
is respected.
   3. Test that setting up a `DATABASE_OAUTH2_REDIRECT_URI` is respected.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to