tiya-9975 commented on code in PR #37302:
URL: https://github.com/apache/superset/pull/37302#discussion_r2715330427
##########
docker/apt-install.sh:
##########
@@ -38,9 +38,16 @@ RESET='\033[0m'
echo -e "${GREEN}Updating package lists...${RESET}"
apt-get update -qq
+# Ensure native Python extensions can compile (python-geohash, psycopg2,
mysqlclient)
+echo -e "${GREEN}Installing build toolchain...${RESET}"
+apt-get install -yqq --no-install-recommends \
+ build-essential \
+ g++
+
echo -e "${GREEN}Installing packages: $@${RESET}"
apt-get install -yqq --no-install-recommends "$@"
+
Review Comment:
Thanks for the review!
I’ve updated the PR to rely on Superset’s existing temporary build toolchain
mechanism instead of permanently installing build dependencies, and removed the
redundant g++ entry.
This keeps the Docker image lean and consistent with the current
optimization strategy. Please let me know if this looks good now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
