JCelento opened a new pull request, #37362: URL: https://github.com/apache/superset/pull/37362
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY Issue: Currently, when selecting conditional formatting in a table column, we have options that do not work for non-time comparison data. Root cause: We weren't conditionally showing time comparison specific formatting. Fix: Add a check before deciding whether show or not custom formatting options that depend on time comparison. Related PR: #34523 ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF BEFORE: https://github.com/user-attachments/assets/8b659dd5-c986-4dbe-b88c-31f860837681 AFTER: https://github.com/user-attachments/assets/f00dcbba-edff-457c-9fba-1c3be8ae3bb0 ### TESTING INSTRUCTIONS 1. Create a Table Chart with the following values: X | Y | X-Y -- | -- | -- 1 | 2 | -1 5 | 2 | 3 4 | 2 | 2 1 | 5 | -4 1 | 1 | 0 2. Go to the Customize tab, and add Conditional Formatting to the third column. 3. Choose the Green for increase, red for decrease option. Expected results: The "Green for increase, red for decrease" and "Red for increase, green for decrease" conditional formatting options shouldn't appear unless there is a time shift applied to the table ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: #34141 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
