massucattoj opened a new pull request, #37366: URL: https://github.com/apache/superset/pull/37366
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY Replace Fira Code with IBM Plex Mono as the monospace font (fontFamilyCode theme token). This applies to all SQL editors and numerical display labels throughout the application. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS - SQL Lab Editor 1. Navigate to SQL → SQL Lab 2. Open or create a new query tab 3. Type any SQL in the editor (e.g., SELECT * FROM) 4. Verify: Editor text uses IBM Plex Mono (monospace font) - SQL Lab Timer & Row Count 1. In SQL Lab, run a query 2. Verify: The green timer label (e.g., "00:00:00.117") uses monospace font 3. Verify: The row count label in results (e.g., "146 rows") uses monospace font - Chart Builder Metric Popovers 1. Navigate to Charts → click any chart → Edit 2. Click on a metric field to open the metric popover 3. Switch to "Custom SQL" tab 4. Verify: SQL editor in the popover uses IBM Plex Mono - Dataset Editor SQL Expression 1. Navigate to Datasets → click any dataset → Edit 2. Go to Calculated columns tab 3. Expand any calculated column row (click the + icon) 4. Verify: SQL expression editor uses IBM Plex Mono - Alerts & Reports SQL Editor 1. Navigate to Settings → Alerts & reports 2. Click + Alert to create a new alert 3. Expand Alert condition section 4. Verify: SQL Query editor uses IBM Plex Mono - Query History Duration 1. Navigate to SQL → Query History 2. Verify: Duration labels (green tags like "00:00:00.316") use monospace font ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
