gabotorresruiz opened a new pull request, #37370: URL: https://github.com/apache/superset/pull/37370
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> Original PR: https://github.com/apache/superset/pull/37059 Fixes https://github.com/apache/superset/issues/34865 where APP_NAME configuration stopped working for browser window/tab titles after the Ant Design v5 theme migration in Superset 6.0. **Changes:** - Added brandAppName theme token for application name in window titles - Implemented 3-tier fallback: brandAppName → APP_NAME config → "Superset" - Updated frontend title cleanup to use theme token instead of hardcoded "Superset" - Applied fallback to bootstrap payload so React components receive correct value **Backward compatibility:** Existing `APP_NAME` configurations continue to work automatically via fallback mechanism. ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> 1. Set APP_NAME = "Custom App Name" in `superset_config.py` 2. Start Superset and navigate to login page 3. Verify browser tab shows "Custom App Name" instead of "Superset" 4. Navigate to a dashboard/chart, verify title changes to dashboard name 5. Navigate away, verify title returns to "Custom App Name" **Or test with new theme system:** ```py THEME_DEFAULT = { "token": { "brandAppName": "My Custom Analytics", } } ``` ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: https://github.com/apache/superset/issues/34865 - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
